fix : Ensure rows, conn and db are closed on all error paths #6321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
approved these changes
Dec 23, 2024
k-anshul
added a commit
that referenced
this pull request
Dec 23, 2024
* ensure rows, conn and db are closed on all error paths * revert otelsql change
k-anshul
added a commit
that referenced
this pull request
Jan 6, 2025
* ensure rows, conn and db are closed on all error paths * revert otelsql change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed
otelsqlwrapping around db.Since we don't use sql APIs there are no traces being collected for snowflake db operations.
We have also seen some memory leak issues around
otelsqlso better to remove it. This is just a precautionary change.