Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model executor for postgres and mysql to duckdb #6083

Merged
merged 8 commits into from
Jan 6, 2025
Merged

model executor for postgres and mysql to duckdb #6083

merged 8 commits into from
Jan 6, 2025

Conversation

k-anshul
Copy link
Member

@k-anshul k-anshul commented Nov 12, 2024 •
edited
Loading

subtask for https://github.com/rilldata/rill-private-issues/issues/854

  • Adds a model executor that ingests data from postgres/mysql using duckdb extension.
  • Also supports incremental ingestion.

Sample model yaml that ingests from postgres.

connector: postgres
sql: SELECT * FROM students 
dsn: "postgresql://postgres:postgres@localhost:5432/postgres"

output:
  connector: duckdb

@k-anshul k-anshul self-assigned this Nov 12, 2024
@k-anshul k-anshul changed the title model executor for postgres to duckdb model executor for postgres and mysql to duckdb Nov 13, 2024
@k-anshul k-anshul marked this pull request as draft November 13, 2024 13:35
@k-anshul k-anshul marked this pull request as ready for review December 18, 2024 09:10
@k-anshul k-anshul assigned AdityaHegde and k-anshul and unassigned k-anshul and AdityaHegde Dec 20, 2024
@k-anshul k-anshul merged commit a3e72bc into main Jan 6, 2025
7 checks passed
@k-anshul k-anshul deleted the me_postgres_duckdb branch January 6, 2025 10:46
k-anshul added a commit that referenced this pull request Jan 6, 2025
@k-anshul @begelundmuller
model executor for postgres and mysql to duckdb (#6083)
7b5590c 
* model executor for postgres/mysql to duckdb

* fix postgres unit test

* table name is not guaranted to be present for all models

* review comments

* also allow inline variables

* also add dsn for postgres

* also add dsn for postgres

* Update runtime/drivers/duckdb/model_executor_sqlstore_self.go

Co-authored-by: Benjamin Egelund-Müller <[email protected]>

---------

Co-authored-by: Benjamin Egelund-Müller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

Assignees

@k-anshul k-anshul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-anshul @begelundmuller @AdityaHegde