fix: type errors for unsafe access (#5504)

rilldata · Aug 22, 2024 · 075e80e · 075e80e · github-actions · Aug 22, 2024
1 parent fcbfa88
commit 075e80e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/web-common/src/features/dashboards/pivot/pivot-merge-filters.ts b/web-common/src/features/dashboards/pivot/pivot-merge-filters.ts
@@ -37,7 +37,7 @@ export function mergeFilters(
       if (likeExprMap.has(ident)) return;
       likeExprMap.set(ident, e);
     } else {
-      if (inExprMap.has(ident) || !!e.cond?.exprs?.[1].subquery) return;
+      if (inExprMap.has(ident) || !!e.cond?.exprs?.[1]?.subquery) return;
       inExprMap.set(ident, e);
     }
   });
@@ -51,7 +51,7 @@ export function mergeFilters(
       e.cond?.op === V1Operation.OPERATION_NLIKE
     )
       return;
-    if (!inExprMap.has(ident) || !!e.cond?.exprs?.[1].subquery) return;
+    if (!inExprMap.has(ident) || !!e.cond?.exprs?.[1]?.subquery) return;
 
     /**
      * We take an intersection of the values in the IN expressions.

diff --git a/web-common/src/features/dashboards/time-dimension-details/TimeDimensionDisplay.svelte b/web-common/src/features/dashboards/time-dimension-details/TimeDimensionDisplay.svelte
@@ -267,7 +267,7 @@
         </div>
       </div>
     </div>
-  {:else if comparing === "dimension" && formattedData.rowCount === 1}
+  {:else if comparing === "dimension" && formattedData?.rowCount === 1}
     <div class="w-full h-full">
       <div class="flex flex-col items-center h-full text-sm">
         <div class="text-gray-600">No search results to show</div>