Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a public get_tree() method and have print_tree use it #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tupshin
Copy link

@tupshin tupshin commented Jan 31, 2020

Note that I found this useful when debugging and I didn't have access to a
normal stdout.

Note that I found this useful when debugging and I didn't have access to a
normal stdout.
@hardliner66
Copy link
Contributor

hardliner66 commented Feb 6, 2020

I don't think exposing a string representation of the internal state is a good idea.

It would be better to just change the println! calls with debug! calls from the log crate. This way you could add a different log targets depending on your needs, without exposing internal state.

@olexiyb
Copy link
Contributor

olexiyb commented Apr 11, 2020

merged it into actors.rs

@leenozara
Copy link
Contributor

Hi @tupshin thanks for the input. I think you've identified a valid problem, however @hardliner66 has a valid point re not using a string representation. My concern would be larger actor systems that have several thousand or more actors and the allocation to append each actor name. Maybe there is a more effective way to solve the problem that you've identified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants