Autocompletion for viewModel/baseType directives #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acizmarik
reviewed
Nov 21, 2022
| try { | ||
| dotvvmspy = require('lib-dotvvm-spy'); | ||
|
|
||
| if (dotvvmspy?.sanityCheck() !== true) { |
There was a problem hiding this comment.
Should not we also check that we are running in a 64-bit process? I may have missed it if it is checked elsewhere
There was a problem hiding this comment.
It would fail to load and crash, but I added the checks for platform and architecture
exyi
force-pushed
the
dotnet-native-analyzer
branch
from
17e5467 to
1e86c74
Compare
…tnet-native-analyzer
exyi
force-pushed
the
dotnet-native-analyzer
branch
2 times, most recently
from
681807c to
24629e8
Compare
exyi
force-pushed
the
dotnet-native-analyzer
branch
from
24629e8 to
7498222
Compare
pkg supports loading additional libraries if the loaded X.node file is on node_modules folder. Our library wasn't, because the node_modules entry was symlinked into another directory. So only the something.node file was loaded, not the libDotvvmSpy.so file
See the parent commit for description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type list comes from ILSpy's typesystem, compiled using .NET native as a shared library (their static linking is broken)
This is mostly a PoC of the ILSpy running in .NET native. It is then loaded to the language server as node addon. It currently only compiles on Linux, it should be similar on MacOŠ, and we can skip Windows for now. The extension should work fine without it.
TODO: