Skip to content

Commit

Permalink
updated WiFi.setHostName()
Browse files Browse the repository at this point in the history
  • Loading branch information
richonguzman committed Sep 2, 2024
1 parent 40fc177 commit 916eb03
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/LoRa_APRS_iGate.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ ________________________________________________________________________________
#include "A7670_utils.h"
#endif

String versionDate = "2024.08.26";
String versionDate = "2024.09.02";
Configuration Config;
WiFiClient espClient;

Expand Down
2 changes: 2 additions & 0 deletions src/wifi_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ namespace WIFI_Utils {
startAP = true;
} else {
uint8_t wifiCounter = 0;
String hostName = "APRS_iGATE " + Config.callsign;
WiFi.setHostname(hostName.c_str());

This comment has been minimized.

Copy link
@petrkr

petrkr Sep 4, 2024

Hostname can not contains spaces and underscores. It maybe works, but it is not by RFC definition

only A-Z, 0-9 and - are allowed characters

https://www.rfc-editor.org/rfc/rfc952

This comment has been minimized.

Copy link
@richonguzman

richonguzman Sep 4, 2024

Author Owner

this was corrected yesterday right away when I updated like this:

now: "IGATE-"+Config.callsing

This comment has been minimized.

Copy link
@petrkr

petrkr Sep 4, 2024

I see, I did not read commit with message "UP", but only this about Hostname.

It's obsolete comment then :)

WiFi.mode(WIFI_STA);
WiFi.disconnect();
delay(500);
Expand Down

0 comments on commit 916eb03

Please sign in to comment.