Use attach method for has many attachments #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkey patch gemfile
… is supported for rails >= 6. bump minor version
…hments Use attach method to add files in has_many_attachments relation. THIS…
fix bug
Tao-Galasse
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
This should clearly be merged & deployed on Rubygems 🚀
Do you think you could take a moment to do this @richardvenneman please? 😊 🙏
Co-authored-by: taogt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does four things:
I'm aware of
config.active_storage.replace_on_assign_to_many = false, but I think it's good not to rely on the legacy fallback option.