Skip to content

Commit

Permalink
Remove all unnecessary white spaces at the end of lines (kubeflow#2371)
Browse files Browse the repository at this point in the history
* Remove all unnecessary white spaces at the end of lines

* Revert non-text files
  • Loading branch information
ashahba authored and k8s-ci-robot committed Feb 5, 2019
1 parent 3a29c8b commit 910e7ef
Show file tree
Hide file tree
Showing 99 changed files with 1,760 additions and 1,760 deletions.
2 changes: 1 addition & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -396,4 +396,4 @@ exclude-protected=_asdict,_fields,_replace,_source,_make

# Exceptions that will emit a warning when being caught. Defaults to
# "Exception"
overgeneral-exceptions=Exception
overgeneral-exceptions=Exception
2 changes: 1 addition & 1 deletion ROADMAP.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,4 @@ With a growing community of developers across Kubeflow there is a need to build/
* Scalable testing across platforms: GPU Testing, Different base images, multiple H/W and Cloud platforms.
* Upgrade testing.
* [Testing Issues](https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+org%3Akubeflow+label%3Aarea%2Ftesting)
* [Build/Release issues](https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+org%3Akubeflow+label%3Aarea%2Fbuild-release+)
* [Build/Release issues](https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+org%3Akubeflow+label%3Aarea%2Fbuild-release+)
2 changes: 1 addition & 1 deletion ack_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ kfctl.sh init myapp --platform ack
cd myapp
kfctl.sh generate all
kfctl.sh apply all
```
```
2 changes: 1 addition & 1 deletion bootstrap/.gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/lib
/.ksonnet/registries
/app.override.yaml
/reg_tmp/**
/reg_tmp/**
2 changes: 1 addition & 1 deletion bootstrap/DockerfileDebug
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ COPY --from=debug_util $GOPATH/bin/dlv $GOPATH/bin/dlv
RUN chmod a+rx $GOPATH/bin/dlv
COPY dlv.sh /opt/kubeflow/

EXPOSE 2345
EXPOSE 2345
2 changes: 1 addition & 1 deletion bootstrap/build_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# A simple script to build the Docker images.
# This is intended to be invoked as a step in Argo to build the docker image.
#
# build_image.sh ${DOCKERFILE} ${IMAGE} ${TAG}
# build_image.sh ${DOCKERFILE} ${IMAGE} ${TAG}
set -ex

GCLOUD_PROJECT=${GCLOUD_PROJECT:-kubeflow-images-public}
Expand Down
2 changes: 1 addition & 1 deletion bootstrap/cleanup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace=$1
kubectl get ns|grep kubeflow-admin 1>/dev/null
if [[ $? == "0" ]]; then
can_i=$(kubectl auth can-i delete namespace)
case "$can_i" in
case "$can_i" in
yes)
echo Removing kubeflow-admin namespace
kubectl delete ns kubeflow-admin
Expand Down
2 changes: 1 addition & 1 deletion bootstrap/debug.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ image=gcr.io/$GCLOUD_PROJECT/bootstrapper
tag=latest
port=2345

case "$#" in
case "$#" in
0)
;;
1)
Expand Down
24 changes: 12 additions & 12 deletions bootstrap/developer_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,49 +20,49 @@ $ ☞ go version
go version go1.11.2 darwin/amd64
```

On mac osx you can run
On mac osx you can run

```sh
brew upgrade golang
```

golang-1.11.2 uses go.mod, go.sum files which include dependencies.
To install a new dependency use `go get <dependency>`.
To install a new dependency use `go get <dependency>`.
golang-1.11.2 no longer creates a vendor directory.
You should add the environment variable `GO111MODULE=on` to your shell init file

### Makefile targets

```
build debug push
build-local debug-latest push-latest
cleanup
build debug push
build-local debug-latest push-latest
cleanup
```

#### `make build-local`
Creates bin/bootstrapper with full debug information

#### `make build`
#### `make build`
Depends on `make build-local`. Creates a docker image gcr.io/$(GCLOUD_PROJECT)/bootstrapper:$(TAG)

#### `make push`
#### `make push`
Depends on `make build`. Pushes the docker image gcr.io/$(GCLOUD_PROJECT)/bootstrapper:$(TAG)

#### `make push-latest`
#### `make push-latest`
Depends on `make push`. Tags the docker image gcr.io/$(GCLOUD_PROJECT)/bootstrapper:$(TAG) with latest.
Note: To use a different gcloud project than kubeflow-images-public.
Note: To use a different gcloud project than kubeflow-images-public.
```sh
export GCLOUD_PROJECT=mygcloudproject
export GCLOUD_PROJECT=mygcloudproject
make push
```

#### `make debug`
#### `make debug`
Depends on `make push` and `make cleanup`
1. deploys a Namespace, PersistentVolumeClaim and StatefulSet using $(IMG), $(TAG), $(PORT)
2. waits for pod kubeflow-bootstrapper-0 to be in phase 'Running'
3. runs "kubectl port-forward ..." in the background, opening port 2345 to the pod's container
4. wait - cleanup (kill port-forward command) on Ctrl-C
5. when the script exits (Ctrl-C) it will kill "kubectl port-forward ..."
5. when the script exits (Ctrl-C) it will kill "kubectl port-forward ..."
6. in order to clean up all resources deployed in step 1 run `make cleanup`

The StatefulSet will create a pod and start the following process in the pod's kubeflow-bootstrapper-0 container
Expand Down
2 changes: 1 addition & 1 deletion bootstrap/dlv.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/usr/bin/env sh

dlv --listen=:2345 --headless=true --api-version=2 exec /opt/kubeflow/bootstrapper -- --in-cluster --namespace=kubeflow
dlv --listen=:2345 --headless=true --api-version=2 exec /opt/kubeflow/bootstrapper -- --in-cluster --namespace=kubeflow
2 changes: 1 addition & 1 deletion components/build_image.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def build_tf_notebook(args):
run(command, cwd=context_dir)

if args.push_gcr:
run(["gcloud", "auth", "activate-service-account", "--key-file", os.environ['GOOGLE_APPLICATION_CREDENTIALS']])
run(["gcloud", "auth", "activate-service-account", "--key-file", os.environ['GOOGLE_APPLICATION_CREDENTIALS']])
run(["gcloud", "docker", "--", "push", image_name])

def main():
Expand Down
2 changes: 1 addition & 1 deletion components/centraldashboard/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ push: build

push-latest: push
gcloud container images add-tag --quiet $(IMG):$(TAG) $(IMG):latest --verbosity=info
echo created $(IMG):latest
echo created $(IMG):latest
4 changes: 2 additions & 2 deletions components/centraldashboard/frontend/index/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:regular,bold,italic,thin,light,bolditalic,black,medium|Google+Sans&lang=en">
<link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">
<link rel="stylesheet" href="styles.css">

<!-- Third Party -->
<!-- Polymer CDN Courtesy of https://github.com/download/polymer-cdn -->
<script src="https://cdn.rawgit.com/download/polymer-cdn/2.6.0/lib/webcomponentsjs/webcomponents-loader.js"></script>
Expand All @@ -21,4 +21,4 @@
<body>
<main-page></main-page>
</body>
</html>
</html>
4 changes: 2 additions & 2 deletions components/centraldashboard/frontend/layout/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">
<link rel="stylesheet" href="https://code.getmdl.io/1.3.0/material.orange-light_blue.min.css" />
<link rel="stylesheet" href="styles.css">

<!-- Bootstrap CSS -->
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-beta.3/css/bootstrap.min.css" integrity="sha384-Zug+QiDoJOrZ5t4lssLdxGhVrurbmBWopoEl+M6BdEfwnCJZtKxi1KgxUyJq13dy" crossorigin="anonymous">

Expand All @@ -28,7 +28,7 @@ <h1>Kubeflow</h1>
<a href="/tfjobs/ui/" class="mdl-layout__tab mdl-color-text--white">TFJob Dashboard</a>
<a href="/katib/" class="mdl-layout__tab mdl-color-text--white">Katib Dashboard</a>
<a href="/pipeline/" class="mdl-layout__tab mdl-color-text--white">Pipeline Dashboard</a>
</div>
</div>
</header>
<br>
<br>
Expand Down
4 changes: 2 additions & 2 deletions components/contrib/kaggle-notebook-image/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ENV PATH $CONDA_DIR/bin:$PATH
# Use bash instead of sh
SHELL ["/bin/bash", "-c"]

# add https support
# add https support
RUN apt-get update && apt-get install -yq --no-install-recommends apt-transport-https

RUN echo "en_US.UTF-8 UTF-8" > /etc/locale.gen && \
Expand Down Expand Up @@ -64,7 +64,7 @@ ADD --chown=jovyan:users $GITHUB_REF/jupyter_notebook_config.py /tmp
WORKDIR $HOME
RUN rm -fr $(ls -A $HOME)

# Get init scripts from kubeflow
# Get init scripts from kubeflow
ADD --chown=jovyan:users \
$GITHUB_REF/start-singleuser.sh \
$GITHUB_REF/start-notebook.sh \
Expand Down
2 changes: 1 addition & 1 deletion components/contrib/kaggle-notebook-image/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Important notes:
* this notebook is not curated by the Kubeflow project and is not regularly tested
* the versions of TensorFlow, PyTorch, and the other libraries included may change at any time
* this is a very large notebook, over 21 Gb in size. Since our notebook uses the latest Kaggle image, docker pulls (and notebook launches) can take a lengthy period of time.
* the base image size for docker devicemapper is 10 Gb, which won't be large enough to run this image. Your docker daemon must be configured for at least 30 Gb (`-storage-opt dm.basesize=30G`) or use a storage driver like overlay2.
* the base image size for docker devicemapper is 10 Gb, which won't be large enough to run this image. Your docker daemon must be configured for at least 30 Gb (`-storage-opt dm.basesize=30G`) or use a storage driver like overlay2.
* the Kaggle image includes TensorFlow 1.9 or greater built with AVX2 support, so the image may not run on older CPU
* the other Kubeflow curated notebooks have the feature that the jovyan user is able to install new packages from pip or conda. Unfortunately this is not the case with the Kaggle image due to the impact on the image size due to adding a new ownership layer.

Expand Down
4 changes: 2 additions & 2 deletions components/contrib/rapidsai-notebook-image/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ ENV PATH /usr/local/nvidia/bin:$PATH
# Use bash instead of sh
SHELL ["/bin/bash", "-c"]

# add https support
# add https support
RUN apt-get update && apt-get install -yq --no-install-recommends \
apt-transport-https locales lsb-release wget

Expand Down Expand Up @@ -66,7 +66,7 @@ ADD --chown=jovyan:users $GITHUB_REF/jupyter_notebook_config.py /tmp
WORKDIR $HOME
RUN rm -fr $(ls -A $HOME)

# Get init scripts from kubeflow
# Get init scripts from kubeflow
ADD --chown=jovyan:users \
$GITHUB_REF/start-notebook.sh \
$GITHUB_REF/start-singleuser.sh \
Expand Down
8 changes: 4 additions & 4 deletions components/echo-server/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ IMG = gcr.io/kubeflow-images-staging/echo-server
PUBLIC = gcr.io/kubeflow-images-public/echo-server
DIR := ${CURDIR}

# List any changed files.
# List any changed files.
CHANGED_FILES := $(shell git diff-files --relative=components/echo-server)

ifeq ($(strip $(CHANGED_FILES)),)
Expand All @@ -43,13 +43,13 @@ build:
# Build but don't attach the latest tag. This allows manual testing/inspection of the image
# first.
push: build
gcloud docker -- push $(IMG):$(TAG)
gcloud docker -- push $(IMG):$(TAG)
@echo Pushed $(IMG) with :$(TAG) tags

push-latest: push
gcloud container images add-tag --quiet $(IMG):$(TAG) $(IMG):latest --verbosity=info
echo created $(IMG):latest

push-public: push-latest
gcloud container images add-tag --quiet $(IMG):$(TAG) $(PUBLIC):$(TAG) --verbosity=info
gcloud container images add-tag --quiet $(IMG):$(TAG) $(PUBLIC):latest --verbosity=info
gcloud container images add-tag --quiet $(IMG):$(TAG) $(PUBLIC):latest --verbosity=info
2 changes: 1 addition & 1 deletion components/gatekeeper/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ RUN chmod a+rx /opt/kubeflow/gatekeeper

EXPOSE 8085

CMD ["/opt/kubeflow/gatekeeper"]
CMD ["/opt/kubeflow/gatekeeper"]
2 changes: 1 addition & 1 deletion components/gatekeeper/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ golang to 1.11.2
```sh
$ ☞ go version
go version go1.11.2 darwin/amd64
```
```
8 changes: 4 additions & 4 deletions components/gcp-click-to-deploy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
A simple react webapp to make it easy to deploy Kubeflow on GCP.

The webapp is a client side javascript. The webapp provides a UI
to guide the user through the process of specifying the
to guide the user through the process of specifying the
information needed to deploy Kubeflow e.g.

* The project they want to use
* The name for deployment

Expand All @@ -18,7 +18,7 @@ Furthermore, the app makes it easy for the user to login to Google using the
web auth flow and obtain a credential needed to perform the necessary GCP actions.
This is needed to perform admin tasks needed to setup Kubeflow.

The credential is never sent to Kubeflow servers. The credential is stored clientside
The credential is never sent to Kubeflow servers. The credential is stored clientside
in the web app and used in requests to GCP services when needed.

## Development
Expand Down Expand Up @@ -70,5 +70,5 @@ The script
```
./ks-app/create_gcp_deploy_sa.sh
```

Can be used to create a service account to work with external DNS.
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRole
metadata:
name: external-dns
name: external-dns
rules:
- apiGroups: [""]
resources: ["services"]
verbs: ["get","watch","list"]
- apiGroups: [""]
resources: ["pods"]
verbs: ["get","watch","list"]
- apiGroups: ["extensions"]
resources: ["ingresses"]
- apiGroups: ["extensions"]
resources: ["ingresses"]
verbs: ["get","watch","list"]
- apiGroups: [""]
resources: ["nodes"]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ spec:
- --source=service
- --source=ingress
# will make ExternalDNS see only the hosted zones matching provided domain, omit to process all available hosted zones
- --domain-filter=kubeflow.dev
- --domain-filter=kubeflow.dev
- --provider=google
# Use this to specify a project different from the one external-dns is running inside
- --google-project=kubeflow-dns
- --google-project=kubeflow-dns
- --policy=upsert-only # would prevent ExternalDNS from deleting any records, omit to enable full synchronization
- --registry=txt
- [email protected]
Expand All @@ -36,4 +36,4 @@ spec:
volumes:
- name: sa
secret:
secretName: gcp-sa
secretName: gcp-sa
2 changes: 1 addition & 1 deletion components/https-redirect/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ push: build
gcloud docker -- push $(IMG):$(TAG)

push-latest: push
gcloud docker -- push $(IMG):$(TAG)
gcloud docker -- push $(IMG):$(TAG)
10 changes: 5 additions & 5 deletions components/k8s-model-server/http-proxy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

## Why?

TF serving only supports gRPC, which means you need to have a client to be able to query it.
TF serving only supports gRPC, which means you need to have a client to be able to query it.

This component provides web server that proxy http rest api to Tensorflow/Serving grpc.

Expand Down Expand Up @@ -59,10 +59,10 @@ or
- **Response**:

```javascript
{"predictions":
{"predictions":
[
{"tf_model_output": "pred_value1"},
{"tf_model_output": "pred_value2"},
{"tf_model_output": "pred_value1"},
{"tf_model_output": "pred_value2"},
]
}

Expand Down Expand Up @@ -99,7 +99,7 @@ or
- **Response**:

```javascript
{"result":
{"result":
{"classifications": [
{"classes": [{"score": 0.0, "label": "0"}, {"score": 1.0, "label": "1"}]},
{"classes": [{"score": 0.0, "label": "0"}, {"score": 1.0, "label": "1"}]},
Expand Down
Loading

0 comments on commit 910e7ef

Please sign in to comment.