Allow setting custom options for Faraday, like proxy or SSL certs #106
Conversation
| Ribose::Request.get("ping") | ||
|
|
||
| expect( | ||
| a_request(:any, //).with(headers: custom_headers) |
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
| custom_headers = {"X-Set-In-Config" => "Yes"} | ||
|
|
||
| stub_configuration do |config| | ||
| config.faraday_options = {headers: custom_headers} |
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
| @@ -60,6 +60,21 @@ | |||
| end | |||
| end | |||
|
|
|||
| example "custom Faraday options from configuration are used" do | |||
| custom_headers = {"X-Set-In-Config" => "Yes"} | |||
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
| file_upload = Ribose::FileUploader.upload(space_id, file_attributes) | ||
|
|
||
| expect( | ||
| a_request(:any, //).with(headers: custom_headers) |
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
| end | ||
|
|
||
| stub_ribose_space_file_upload_api(space_id, file_attributes) | ||
| file_upload = Ribose::FileUploader.upload(space_id, file_attributes) |
There was a problem hiding this comment.
Useless assignment to variable - file_upload.
| custom_headers = {"X-Set-In-Config" => "Yes"} | ||
|
|
||
| stub_configuration do |config| | ||
| config.faraday_options = {headers: custom_headers} |
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
| @@ -16,6 +16,22 @@ | |||
| end | |||
| end | |||
|
|
|||
| example "custom Faraday options from configuration are used" do | |||
| space_id = 123_456_789 | |||
| custom_headers = {"X-Set-In-Config" => "Yes"} | |||
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
| @@ -9,17 +9,20 @@ | |||
| api_host = "www.example.com" | |||
| api_token = "SUPER_SECRET_API_TOKEN" | |||
| user_email = "[email protected]" | |||
| faraday_options = {some: :options} | |||
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
| Ribose::Request.get("ping") | ||
|
|
||
| expect( | ||
| a_request(:any, //).with(headers: custom_headers) |
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
| custom_headers = {"X-Set-In-Config" => "Yes"} | ||
|
|
||
| stub_configuration do |config| | ||
| config.faraday_options = {headers: custom_headers} |
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
| @@ -60,6 +60,21 @@ | |||
| end | |||
| end | |||
|
|
|||
| example "custom Faraday options from configuration are used" do | |||
| custom_headers = {"X-Set-In-Config" => "Yes"} | |||
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
| file_upload = Ribose::FileUploader.upload(space_id, file_attributes) | ||
|
|
||
| expect( | ||
| a_request(:any, //).with(headers: custom_headers) |
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
| end | ||
|
|
||
| stub_ribose_space_file_upload_api(space_id, file_attributes) | ||
| file_upload = Ribose::FileUploader.upload(space_id, file_attributes) |
There was a problem hiding this comment.
Useless assignment to variable - file_upload.
| custom_headers = {"X-Set-In-Config" => "Yes"} | ||
|
|
||
| stub_configuration do |config| | ||
| config.faraday_options = {headers: custom_headers} |
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
| @@ -16,6 +16,22 @@ | |||
| end | |||
| end | |||
|
|
|||
| example "custom Faraday options from configuration are used" do | |||
| space_id = 123_456_789 | |||
| custom_headers = {"X-Set-In-Config" => "Yes"} | |||
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
| @@ -9,17 +9,20 @@ | |||
| api_host = "www.example.com" | |||
| api_token = "SUPER_SECRET_API_TOKEN" | |||
| user_email = "[email protected]" | |||
| faraday_options = {some: :options} | |||
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
|
Due to reasons outlined in #94 (comment), do not merge before aproval. |
There was a problem hiding this comment.
Thanks @skalee, We want to go as minimal as possible, as we might even consider that disabling ssl support in the future (details on the issue).
So instead of making whole faraday customisable, what do you think about only adding one option something like Ribose.configuration.ssl_verify_mode, and set defaults to true and update client reference?
Edit:
And let's not change anything in faraday config in file uploader, as the upload url is returned from our file upload API and it's aws url, which should not require us to disable SSL.
Fixes #105.