Account/safe7579 #84
Merged
Account/safe7579 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nlordell would love to get your feedback on this launchpad implementation :) |
kopy-kat
reviewed
Mar 14, 2024
| { | ||
| address validationModule = address(bytes20(data[:20])); | ||
|
|
||
| if (!_isValidatorInstalled(validationModule)) return 0xFFFFFFFF; |
There was a problem hiding this comment.
should we also use safe if validationModule is address(0)
if no signature or address(0) validation module or an not installed 7579 validation module is provided within the abi.encodePacked signature data in erc1271, it falls back to safe's signature check
Account/safe7579 fix1271
nlordell
reviewed
Apr 5, 2024
| bool success; | ||
| // this is the return data from the Safe.execTransactionFromModuleReturnData call. NOT the | ||
| // simulation | ||
| (success, returnData) = ISafe(safe).execTransactionFromModuleReturnData( |
There was a problem hiding this comment.
I think this should use simulateWithRevert (since this emits an event which would be a problem if the Safe was static called).
wip foo wip wip 📝 More docs adding docs fix wip wip
ocs fix fix asdf WIP foo ref wip
multi module type clean
🔥 Changing initAccount to only use validators for ERC4337 compliance
wip
zeroknots
force-pushed
the
account/safe7579
branch
from
7cb599a to
471e96b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented some of @nlordell feedback.
msg.sigspecific handler.