modify regex in StandardProblem.parse so we can load .tsp files we wrote #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StandardProblem.write places EOF at the end of the file. The TSPLIB standard
specifies that EOF is a keyword and so is expected to be followed by a ":".
StandardProblem.parse respected this aspect of the standard and so refused
to match EOF unless it was followed by ":" or whitespace. We add that the file
end ("\Z" in regex terms) is also acceptable so that the output of StandardProblem.write
is acceptable input to StandardProblem.parse
|
The CI tests don't appear to run anymore, but I ran both pytest (EDIT: and tox) on my local machine for py3.8 only and all tests passed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StandardProblem.write places EOF at the end of the file. The TSPLIB standard specifies that EOF is a keyword and so is expected to be followed by a ":". StandardProblem.parse respected this aspect of the standard and so refused to match EOF unless it was followed by ":" or whitespace. We add that the file end ("\Z" in regex terms) is also acceptable so that the output of StandardProblem.write is acceptable input to StandardProblem.parse