grub-mkstandalone: reduce sharp edges #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
grub-mkstandalone-usability
branch
from
9a6ec1c
to
0f06cdb
Compare
It is a major foot gun that grub-mkstandalone silently drops files. As a first step, we can improve documentation and add warn messages. Signed-off-by: Philipp Schuster <[email protected]>
phip1611
force-pushed
the
grub-mkstandalone-usability
branch
from
0f06cdb
to
0c0c9d7
Compare
|
@phip1611 You can send your patch upstream first by following the steps on https://www.gnu.org/software/grub/grub-development.html. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a major foot gun that grub-mkstandalone silently drops files. As a first step, we can improve documentation and add warn messages.
PS: I'm aware that this is a RO mirror. I just wanted to save this for better google-ability for others. I'm going to contribute this the regular way soon, hopefully. (Guidance, please?) Or can one you, the maintainers, just copy, paste, and apply the patch?
PPS: I have to build and test this locally as well (WIP).