Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and push Docker image on tag #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvitale1989
Copy link

@mvitale1989 mvitale1989 commented Jun 29, 2024

Thank you for this awesome project! This PR adds support for docker image build&publish to the Github image registry, when a tag is pushed.

If e.g. tagging a commit as v1.3.0, this workflow will make the image available as:

  • ghcr.io/rhasspy/wyoming-satellite:1.3.0
  • ghcr.io/rhasspy/wyoming-satellite:1.3
  • ghcr.io/rhasspy/wyoming-satellite:latest

I had built the 1.2.0 image for myself (can be inspected with docker pull ghcr.io/mvitale1989/wyoming-satellite:1.2.0-1, with a slightly different tagging scheme) to use it in my k8s cluster, but it'd be great if this is done in the project repo itself.

The additional dependencies are useful client tools to record/play sound against the most common sound servers.

@florian-asche
Copy link

Did you build one image and use it for all different containers?

@mvitale1989
Copy link
Author

Did you build one image and use it for all different containers?

If you're referring to my Kubernetes deployment, I only built the wyoming-satellite image. The other containers use other images which were already publicly available (e.g. wyoming-piper, wyoming-whisper and wyoming-openwakeword are all on Docker Hub already)

@florian-asche
Copy link

florian-asche commented Nov 24, 2024

I improved your work a bit (i hope).
See #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants