Fix compiler warnings #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
commented
Nov 28, 2023
| @@ -103,7 +103,7 @@ target_link_libraries(espeak-ng PRIVATE espeak-ng-config ucd) | |||
| if (NOT MSVC) | |||
| target_link_libraries(espeak-ng PRIVATE m) | |||
| endif() | |||
| target_link_libraries(espeak-ng PUBLIC espeak-include) | |||
There was a problem hiding this comment.
This line using PUBLIC causes errors when building for linux aarch64. I have spent half a day to figure it out.
https://github.com/rhasspy/espeak-ng/tree/master/src/include/compat
The above folder contains many header files that share the same name with the standard library headers. It is really bad to also include it in the header search path.
(It is even worse to name them using standard library header filenames.)
csukuangfj
commented
Nov 29, 2023
| @@ -39,6 +39,7 @@ add_library(espeak-ng | |||
| ) | |||
|
|
|||
| target_include_directories(espeak-ng BEFORE PRIVATE $<TARGET_PROPERTY:espeak-include,INTERFACE_INCLUDE_DIRECTORIES>) | |||
| target_link_libraries(espeak-ng PRIVATE "-Wl,-rpath,${ESPEAK_NG_RPATH_ORIGIN}") | |||
There was a problem hiding this comment.
This commit should fix
rhasspy/piper#286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.