Let user specify machine-labels (#65)

* Let user specify machine-labels Signed-off-by: David J. M. Karlsen <[email protected]> * fix review-comments Signed-off-by: David J. M. Karlsen <[email protected]> * Bump chart minor version as we're changing semantics Signed-off-by: David J. M. Karlsen <[email protected]> * don't default here either Signed-off-by: David J. M. Karlsen <[email protected]> --------- Signed-off-by: David J. M. Karlsen <[email protected]> Co-authored-by: David J. M. Karlsen <[email protected]>
rh-mobb · Sep 6, 2023 · 834f3e7 · 834f3e7
1 parent 587f136
commit 834f3e7
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/charts/aro-machinesets/Chart.yaml b/charts/aro-machinesets/Chart.yaml
@@ -3,7 +3,7 @@ name: aro-machinesets
 description: A Helm chart to configure machinesets for ARO
 type: application
 
-version: 0.1.2
+version: 0.2.0
 maintainers:
   - name: paulczar
 home: https://github.com/rh-mobb/helm-charts
diff --git a/charts/aro-machinesets/README.md b/charts/aro-machinesets/README.md
@@ -1,6 +1,8 @@
 # Helm Chart to set up extra MachineSets on ARO clusters
 
-This Helm chart will set up extra MachineSets on ARO clusters. The Defaults will configure them to be infra nodes. see [./values.yaml](values.yaml) for configurable options.
+This Helm chart will set up extra MachineSets on ARO clusters.
+The defaults are un-opinionated about the type of nodes.
+See [./values.yaml](values.yaml) for configurable options, and how to make the machineset suitable as infra-nodes.
 
 
 ## Prerequisites

diff --git a/charts/aro-machinesets/values.yaml b/charts/aro-machinesets/values.yaml
@@ -7,15 +7,19 @@ vmSize: Standard_D4s_v3
 zoneCount: 3
 replicasPerZone: 1
 
-# default will create infra nodes
-machineRole: "infra"
+# define type type of role
+machineRole: "TBD"
+# for infra nodes use:
+# machineRole: "infra"
 
-machineLabels:
-  node-role.kubernetes.io/infra: ""
+machineLabels: {}
+  # uncomment this to have infra-nodes
+  # node-role.kubernetes.io/infra: ""
 
-machineTaints:
-  - key: node-role.kubernetes.io/infra
-    effect: NoSchedule
+machineTaints: {}
+  # uncomment this to have dedicated infra-nodes with taints
+  # - key: node-role.kubernetes.io/infra
+  #  effect: NoSchedule
 
 ## Ignore these unless using `helm template` as they're auto-discovered.
 clusterSpec: