B_LAST_USED_BALL and .importance #5834
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
B_LAST_USED_BALLdoes not take importance into consideration.This patch fixes it and will not run
RemoveBagItemif it sees the item (probably a ball) has.importance = 1.Useful for projects that have some sort of infinite pokeball item.
Feature(s) this PR does NOT handle:
If something like "last healing item" exists, this does not cover it.
Things to note in the release changelog:
B_LAST_USED_BALLfrom removing balls with.importance = 1disc
47929991024