Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ally Switch extra battlerId tracking #5823

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ghoulslash
Copy link
Collaborator

See original PR here #5804

Fixes and adds tests for:

Sky Drop + Ally Switch as the target
Sky Drop + Ally Switch as the attacker
Sticky web on opposing side
All side timer battlerIds. These are not necessary, but makes ally switch robust to any future effects that might care about who sets reflect, for example
Future Sight. If it's been set up against a side that uses ally switch, need to swap the tracked battler/party IDs
Wish. If we use wish and then ally switch, need to update party ID

…sight and wish. add tests for sky drop and stick web
@AlexOn1ine AlexOn1ine merged commit 11bc9bd into rh-hideout:master Dec 18, 2024
1 check passed
@hedara90 hedara90 added the bugfix Bugfixes label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants