Fixes Recoil if Miss effect if crashed into absorb ability #5726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reverted the addition of the effect because it can silently break users move. I think it wasn't a great call to check the recoil instead of effect because this can break elsewhere but when mixed with different effects. Though as long as it doesn't cause issues in vanilla it is fine. Users will probably test their new moves and notice something is wrong. |
AlexOn1ine
added
bugfix
|
please either solve conflicts or supersede |
Dyou want to go through the review process for this still? If so I'll solve conflicts, if not we can supersede. |
feel free to do whatever you think is best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5477
Outside of this fix I created a regular effect for recoil moves because I can't guarantee that there aren't going to be bugs if you mix in other move effects with recoil effects that go through moveend.