Refactor battle terrain

[fdeblasio]

Description

Consolidates a lot of BATTLE_TERRAIN properties into a new gBattleTerrainInfo

Feature(s) this PR does NOT handle:

The intro slides in battle_intro.c (I couldn't for the life of me figure out how to get it to work)

Discord contact info

Frankfurter0

[agsmgmaster64]

Any way to include the FRLG handling for the other battle terrain backgrounds to simplify adding/editing terrains further?

[ShinyDragonHunter]

If the battle terrain names are only for the sprite visualiser menu, they don't need to be in the battle terrain info struct imo

[ShinyDragonHunter]

I'd also recommend moving the battle terrain graphics themselves to where the battle terrain info table is for convenience

[fdeblasio]

If the battle terrain names are only for the sprite visualiser menu, they don't need to be in the battle terrain info struct imo

I'd also recommend moving the battle terrain graphics themselves to where the battle terrain info table is for convenience

Done and done!

[Bassoonian]

I think terrain needs to be renamed to environment to avoid confusing it with the actual functional battle terrains (Electric Terrain etc). I would personally put this PR on hold, this this is a PR that needs to go to pret first imo. I'll PR it to pret and keep you up to date :)

EDIT: pret#2014

[pkmnsnfrn]

@fdeblasio I don't think it NEEDS to be part of this PR (but it can be)

Should you also take @agsmgmaster64's suggestions to make it easier to add battle backgrounds using the FRLG method? Josh already ha a tutorial:
https://github.com/pret/pokeemerald/wiki/Improve-the-Loading-of-Battle-Terrain

I was going to do it, but your work conflicts a little and clearly you have a slightly better handle on the system

[fdeblasio]

@fdeblasio I don't think it NEEDS to be part of this PR (but it can be)

Should you also take @agsmgmaster64's suggestions to make it easier to add battle backgrounds using the FRLG method? Josh already ha a tutorial: https://github.com/pret/pokeemerald/wiki/Improve-the-Loading-of-Battle-Terrain

I was going to do it, but your work conflicts a little and clearly you have a slightly better handle on the system

Done: bba5fe1

[ShinyDragonHunter]

Not sure if out of scope for this PR but you could potentially separate the palette for the entry anim and add the pointer to it to the battle terrain table? Would make battle terrain data in the table larger but it could allow for some interesting combinations like grassing sliding across the screen in cave instead of rocks.

The entry anim graphics and tilemaps themselves are already separate

[AsparagusEduardo]

I don't know if you've been checking, but this PR hasn't been compiling since the last commit made to it.

[AlexOn1ine]

I don't know if you've been checking, but this PR hasn't been compiling since the last commit made to it.

It is being held up by pret#2014

[AsparagusEduardo]

It is being held up by pret#2014

Ooooh, ok

[fdeblasio]

I don't know if you've been checking, but this PR hasn't been compiling since the last commit made to it.

Oops, I haven't really been active here in a bit. It's building locally for me so I'm not sure what's breaking the tests here. I can always revert that commit and make it a seperate PR after this one gets merged