Code

Gimmick Refactor#4449

Code

Merged

AlexOn1ine merged 41 commits intorh-hideout:upcomingrh-hideout/pokeemerald-expansion:upcomingfrom AgustinGDLV:pr/gimmick_refactorAgustinGDLV/pokeemerald:pr/gimmick_refactorCopy head branch name to clipboardJun 22, 2024

+2,207-2,657

Commits

Commits on Apr 26, 2024

• consolidated gimmick checks, triggers, communication, and activation; updated test runner

  AgustinGDLV

  committed
  0fba9e9

• Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into pr/gimmick_refactor

  AgustinGDLV

  committed
  8898196

• fixed improper use of .usableGimmick

  AgustinGDLV

  committed
  bafc3f2

• cleaning up battle_dynamax.c, changing function args to u32s

  AgustinGDLV

  committed
  927f15c

Commits on Apr 30, 2024

• fixed '#ifdef TESTING' causing errors

  AgustinGDLV

  committed
  8c5b70f

Commits on May 2, 2024

• updated z-moves to use gimmick interface, pared down redundancies; no AI/tests

  AgustinGDLV

  committed
  2289f58

• added support for z-moves in tests, consolidated gimmick fields

  AgustinGDLV

  committed
  45c0929

• Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into pr/gimmick_refactor

  AgustinGDLV

  committed
  64fb357

• removed ShouldUseMaxMove and .usingMaxMove

  AgustinGDLV

  committed
  01ce4e5

• renamed TryChangeZIndicator, updated z move display

  AgustinGDLV

  committed
  addd03a

• added several z-move tests and fixed various z-move interactions; fixed z-move category calc

  AgustinGDLV

  committed
  1ea39fe

• fixed useless battler arg in GetTypeBasedZMove

  AgustinGDLV

  committed
  6c30bae

Commits on May 3, 2024

• added basic test check for bad Z-Move or Mega usage

  AgustinGDLV

  committed
  0c2a48e

• reworked test runner gimmick functionality; added support for Ultra Burst + Z-Move to test Light That Burns the Sky

  AgustinGDLV

  committed
  02de343

Commits on May 16, 2024

• Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into pr/gimmick_refactor

  AgustinGDLV

  committed
  0ff5eea

Commits on May 18, 2024

• fixed gimmick test logic; fixed damage category override

  AgustinGDLV

  committed
  dc25f84

• fixed mega rayquaza test fail

  AgustinGDLV

  committed
  f3301df

Commits on May 20, 2024

• consolidated gimmick indicator logic; added graphics to gGimmicksInfo

  AgustinGDLV

  committed
  d197aa7

• removed TeraData struct

  AgustinGDLV

  committed
  70a3c99

• reimplemented AI logic for Z-Moves; no changes

  AgustinGDLV

  committed
  dbfd0b1

• updated Z-Move and Ultra Burst trigger gfx

  AgustinGDLV

  committed
  6555305

• added testrunner check for multiple gimmick use

  AgustinGDLV

  committed
  1be7250

• fixed duplicate z-move call in test

  AgustinGDLV

  committed
  ca58010

Commits on May 29, 2024

• reorganized data/graphics/gimmicks.h

  AgustinGDLV

  committed
  fd3235f

• added signature Z-Move ability tests; implemented Guardian of Alola

  AgustinGDLV

  committed
  eef7281

• Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into pr/gimmick_refactor

  AgustinGDLV

  committed
  efc5e60

• fixed bad test update

  AgustinGDLV

  committed
  e795879

Commits on May 30, 2024

• fixed Thousand Arrows not affecting Tera Flying; clean-up

  AgustinGDLV

  committed
  179d4ca

Commits on Jun 5, 2024

• Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into pr/gimmick_refactor

  AgustinGDLV

  committed
  145931d

Commits on Jun 6, 2024

• fixed -ate tests

  AgustinGDLV

  committed
  e6f21c6

• fixed tera tests

  AgustinGDLV

  committed
  544d054

• fixed tera tests really

  AgustinGDLV

  committed
  3f3d56b

Commits on Jun 7, 2024

• fixed last batch of tests

  AgustinGDLV

  committed
  abae734

• fixed -ate mega test again

  AgustinGDLV

  committed
  4bf0fdd

Commits on Jun 10, 2024

• code review

  AgustinGDLV

  committed
  e23f2b0

• Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into pr/gimmick_refactor

  AgustinGDLV

  committed
  fe2bf5a

• code review pt.2

  AgustinGDLV

  committed
  ea80bf6

Commits on Jun 13, 2024

• tweaked CanTera again

  AgustinGDLV

  committed
  1eb2000

Commits on Jun 15, 2024

• Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into pr/gimmick_refactor

  AgustinGDLV

  committed
  35f423d

• dynamax flag only required for player

  AgustinGDLV

  committed
  d434657

• Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into pr/gimmick_refactor

  AgustinGDLV

  committed
  8501cc8