Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Split Harmonium module into submodules and create a macro use Harmonium to import them all #3

Open
jwietelmann opened this issue Jun 13, 2018 · 1 comment
Assignees

Comments

@jwietelmann
Copy link
Contributor

The current single Harmonium module is already pretty long, and it's only going to get longer as we add support for more components.

This issue should not be worked until a plan is laid out for how to arrange the modules. If you have an opinion, drop a comment. We'll update the issue body before starting work on it.

@brianberlin brianberlin self-assigned this Jun 20, 2019
@brianberlin
Copy link
Contributor

Does this work? Looks like @bryanjos has already started that pattern with tables and pagination as well. The only worry i have with this is that as the list of components grows i'd expect to have some name collisions. I originally named the functions tabs/tab and went to tabs_wrapper/tab_item.

But should the function names change to be something like harmonium_tabs/harmonium_tab so we can safely import everything without conflicts. Like right now you wouldn't be able to have a variable named icon in a template file.

Also I'm not sure the point of adding an using macro.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants