Merge pull request #405 from reubenmiller/fix-return-upload-error

fix(c8y microservices create): stop execution on binary upload errors
reubenmiller · Sep 20, 2024 · 68cec1b · 68cec1b
2 parents 3ee67dd + fbfc886
commit 68cec1b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/pkg/cmd/applications/createhostedapplication/createHostedApplication.manual.go b/pkg/cmd/applications/createhostedapplication/createHostedApplication.manual.go
@@ -316,8 +316,7 @@ func (n *CmdCreateHostedApplication) RunE(cmd *cobra.Command, args []string) err
 			n.factory.IOStreams.WaitForProgressIndicator()
 
 			if err != nil {
-				// handle error
-				n.SubCommand.GetCommand().PrintErrf("failed to upload file. %s", err)
+				return fmt.Errorf("failed to upload file. path=%s, err=%s", zipfile, err)
 			} else {
 				applicationBinaryID = resp.JSON("id").String()
 			}

diff --git a/pkg/cmd/microservices/create/create.manual.go b/pkg/cmd/microservices/create/create.manual.go
@@ -281,8 +281,7 @@ func (n *CmdCreate) RunE(cmd *cobra.Command, args []string) error {
 			n.factory.IOStreams.WaitForProgressIndicator()
 
 			if err != nil {
-				// handle error
-				n.SubCommand.GetCommand().PrintErrf("failed to upload file. %s", err)
+				return fmt.Errorf("failed to upload file. path=%s, err=%s", n.file, err)
 			}
 		}
 	} else {