-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement modular biasing options #92
Draft
lobis
wants to merge
29
commits into
master
Choose a base branch
from
lobis-gamma-biasing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…gamma-biasing * origin/lobis-gamma-biasing: [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…gamma-biasing * origin/lobis-gamma-biasing: [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
…gamma-biasing * origin/lobis-gamma-biasing: [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a generic gamma biasing option.
The configuration inside
TRestGeant4Metadata
is as follows:Currently only bremsstrahlung process is biased.
After each secondary gamma produced via bremsstrahlung the following is performed:
If the gamma points towards the point of interest (dot product is positive), then the gamma is multiplied by the split factor, and the weight is adjusted accordingly.
If otherwise the gamma points away from the point of interest, then the gamma will be killed with a probability of
1 - 1/splitFactor
. If it survives the weight will be adjusted accordingly.This weight is a property of Geant4 tracks and it is propagated correctly to secondaries.
This method will allocate more simulation time to gammas pointing towards the detector.
To compute the background rate, each contribution needs to be multiplied by the final weight in order to account for the increased number of events due to biasing.
The XML tag for this new biasing option is
<biasing type="split">
and the default<biasing>
tag is being kept in order to preserve backwards compatibility, the original biasing options remain untouched!