Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding time correction in dataset generation #443

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

ayuberonavarro
Copy link

@ayuberonavarro ayuberonavarro commented Jun 13, 2023

Fonsi7 Medium: 151 Powered by Pull Request Badge

This update will allow to define a control variable available in the analysis tree. Only those time periods where the control variable fulfils certain conditions will be added to the dataset. The algorithm will take care of correcting the dataset run duration for the intermediate run removed periods.

  • Adds new method GetRunDuration that implements run correction using a given analysisTree variable.
  • Adds a dataset validation pipeline.

@jgalan
Copy link
Member

jgalan commented Jun 15, 2023

The dataset.rml is not present, to check that it is coherent with the code.

@jgalan
Copy link
Member

jgalan commented Jun 15, 2023

Inside pipeline/datasets/ there should be the validation macro and the rml.

@jgalan jgalan changed the title TRestDataSet fTimeCorrection data member added Adding time correction in dataset generation Jun 15, 2023
@jgalan jgalan requested a review from cmargalejo June 29, 2023 06:15
@jgalan jgalan mentioned this pull request Jun 12, 2023
5 tasks
@jgalan jgalan marked this pull request as ready for review July 18, 2023 08:46
@jgalan jgalan added the development To define issues with development proposals label Jul 21, 2023
@ayuberonavarro ayuberonavarro requested a review from nkx111 as a code owner April 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development To define issues with development proposals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants