Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding possibility to add a cut on observable parameters in TRestDataSet #386

Merged
merged 21 commits into from
Mar 27, 2023
Merged

Adding possibility to add a cut on observable parameters in TRestDataSet #386

merged 21 commits into from
Mar 27, 2023

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Mar 3, 2023 •
edited
Loading

juanangp Large: 272

Adding possibility to add a cut on observable parameters in TRestDataSet by the use of the Filter function. Note that now the data type of ´fDataSet´ has been chaged from ROOT::RDataFrame to ROOT::RDF::RNode. However, it seems that ROOT::RDataFrame and ROOT::RDF::RNode are handled in a similar way, so it shouldn't affect any underlying code.

  • Migrating to TRestCut inside TRestDataSet
  • Implementing Import function to TRestDataSet
  • Changing Initialize to GenerateDataSet inside TRestDataSet

Contributes to #346

@jgalan
Copy link
Member

jgalan commented Mar 9, 2023

This PR was one of the challenges I asked @IAntolin and @Fonsi7 related to issue #346

Then, perhaps @IAntolin and @Fonsi7 could take over the migration to use TRestCut that I mentioned in the discussions at the PR, so that we can merge this PR and create a new one. I will update the issue.

@juanangp juanangp mentioned this pull request Mar 14, 2023
Merged
pre-commit-ci bot and others added 9 commits March 14, 2023 08:52
@juanangp juanangp requested a review from a team March 23, 2023 10:04
@juanangp juanangp merged commit b830b9a into master Mar 27, 2023
@juanangp juanangp deleted the datasetCut branch March 27, 2023 14:43
jgalan added a commit that referenced this pull request May 3, 2023
@jgalan
Revert "Merge pull request #386 from rest-for-physics/datasetCut"
34e81e6 
This reverts commit b830b9a, reversing
changes made to a6e0b61.
jgalan added a commit that referenced this pull request May 3, 2023
@jgalan
Revert "Revert "Merge pull request #386 from rest-for-physics/dataset…
a10623e 
…Cut""

This reverts commit 34e81e6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgalan jgalan jgalan approved these changes

@KonradAltenmueller KonradAltenmueller KonradAltenmueller approved these changes

@lobis lobis Awaiting requested review from lobis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanangp @jgalan @KonradAltenmueller