New CMake ROOT usage / Minor feature in libraries / Pipeline image change #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobis
changed the title
lobis
changed the title
Closed
|
Why #111 is not yet able to merge? The pipeline is green, and there are no conflicts. Looks like the problem was solved there? |
jgalan
approved these changes
Mar 7, 2022
The pipeline wasn't passing until I updated the docker image. I will merge this code first since its most recent and then that one in case there are any problems, there will be conflicts for sure. |
|
https://gitlab.cern.ch/rest-for-physics/restg4/-/jobs/20061461 pipeline at restG4 at https://gitlab.cern.ch/rest-for-physics/restg4/-/commit/88ce6267fe0c59e892b98b24f911774faacf3595 is failing because its needs XMLIO root library. @jgalan @nkx111 merging #145 will fix this issue. |
nkx111
approved these changes
Mar 8, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @rest-for-physics/core_dev,
This pull request only changes the way we include ROOT on the CMake, since I need to link to a new root library and could not do it otherwise.
This change is also present in #111 but since its not yet able to merge I reimplement it here so that my other changes can pass the pipeline.
Same branch pull requests in other libraries:
rest-for-physics/geant4lib#36
rest-for-physics/detectorlib#34
rest-for-physics/restG4#30
I also changed the docker image for all the repositories mentioned for a new one, which has updated ROOT and Garfield. There are also multiple tags of this image which contain more recent versions of Geant4. I think I finally got the image working and running the pipeline correctly. Previously it was throwing very strange errors but I solved them by upgrading Garfield to the latest commit.