Various commits #44
Merged
Various commits #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Calling the method `java` hides the `java` namespace. - It is not very clear what the method does, without looking at the definition.
Sometimes the difference can be more complex than the full value from a single side. Instead of getting too detailed (and having to adapt the tests too often), stay more general.
... as `close` is a very broad verb, and Scala has problems with applying the syntax implicitly, when a container class implements `close` as well. Similarly, `closeAution` cannot be used, as it is already in use by `RubisInterface`. "Knocked Down" is an auction house term for the hammer coming down and ending the bidding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some various commits that I accumulated and rebased.
I hope these are self-explanatory, if not I'm happy to add some more description.