Test updates #43
Closed
Test updates #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new LastWriterWins implementation already provides a bottom. Fixes: 05d6cb8 ("adapt container tests to different LWW")
- update test case titles - add test case that is not possible for contextual data types
This allows maintainers to trigger a workflow (re-)run from GitHub Actions, optionally for a given commit or branch. The behavior for push and pull_request is unchanged (only syntactic change).
Clearly sequence compilation and testing, making compilation mandatory and do not retry on compilation errors. This adds a slight overhead, as sbt is started one more time. But the steps are more clear, and this avoids the need for `parallelExecution := false`.
- add comment to highlight these are not sequenced - test mirrored diffs - some changes are consumed by the other change
…riables accordingly
EnableWinsFlag is a simple contextual RDT that is easy to be used in a more complex composition. Add this initial test as foundation to build a more complex test case later.
LWW is no longer contextual. Properly document this in the test cases.
…ata type EnableWinsFlag Previously the test case of Dotted[GrowOnlyMap[Int, LastWriterWins[String]]] tested that GrowOnlyMap properly handles the context. Since LWW is no longer contextual, a new test case is needed for that.
…s context and value
|
Looks good as far as I can tell. Let’s see what the CI says to the changes. I did rebase the changes on top of master … no clue how to make this UI understand that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits are fixups of the LWW change.
The next three commits are minor enhancements to the CI.
The remaining commits are doing basically adding more test cases to DecomposeManualTests. This is growing too much and is testing much more than the decompose, but I don't know how to re-structure it better and will leave it as-is.