Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generating sitemap for SEO #6778

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lawrenceching
Copy link
Contributor

WIP.
Good to have a early review.

@auto-assign auto-assign bot requested a review from NGPixel October 13, 2023 16:16
@lawrenceching lawrenceching changed the title Support generating sitemap for SEO WIP: Support generating sitemap for SEO Oct 15, 2023
@BPowell76
Copy link

Any chance on getting this merged? I'd like to add a sitemap to my wiki as I'm using it for my public-facing website. For the time being I can generate a sitemap by hand, but the more pages I have that's going to be tedious and annoying.

@BPowell76
Copy link

BPowell76 commented Nov 10, 2024

@lawrenceching Some things we should add to keep the sitemap compliant, is have an option to set the priority page in the sitemap. Valid values are 0.0 to 1.0. Another thing to add is a change frequency, but a default value could be assigned for monthly or weekly.

Adding the <priority> component to the sitemap and page properties editor will require a change to the database schema by adding a new column.

https://www.sitemaps.org/protocol.html

That said, Google Search Console is indexing my wiki without the sitemap being supplied to it. I guess providing the Google Analytics token in the Administration dashboard is good enough?

@lawrenceching lawrenceching changed the title WIP: Support generating sitemap for SEO Support generating sitemap for SEO Nov 27, 2024
@lawrenceching
Copy link
Contributor Author

@BPowell76
I used a default priority and change frequency for every page.
And allow users to change them in config file.

@NGPixel
I think my change is ready for review. Could you have a look, especially at the permission checking part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants