This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
Git committer name =/= author name #203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bit of a bug with the history feature of wiki.js
Whenever an edit is made, a git commit is made with the change to the repository with the author set to the user logged into wiki.js.
However, when the history is being displayed, the author is shown as the system git name/email rather than the wiki.js user that made the edit.
This is because the
%cEand%cNformat flags are used. As seen on https://git-scm.com/docs/pretty-formats, the author name and committer names can be different, and it is only the author names that are being changed by wiki.js when committing.This pull request fixes the issue. Tested with git v.2.7.4