Recovery Coremod #611
Open
Recovery Coremod #611
+446
−255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhhh yeah something something lint fix and recovery.
like i18n and another setting switch item ;3
changed state type
thanks to uwu pookie bear
used wildcards so I dont have to update classNames every reroll
12944qwerty
requested changes
Apr 9, 2024
FedeIlLeone
requested changes
Apr 10, 2024
| startMainRecovery(); | ||
| instance.setState({ error: null, info: null }); | ||
| }}> | ||
| Recover Discord |
There was a problem hiding this comment.
Not sure what to do here as I removed the other i18n string due to you saying you dont know what would happen with conflicts
| } | ||
|
|
||
| export async function startErrors(): Promise<void> { | ||
| ReactErrors = await fetch(ReactErrorList).then((response) => response.json()); |
There was a problem hiding this comment.
You should also handle in case the fetch fails for some reason.
There was a problem hiding this comment.
Now what should this fallback be.
@12944qwerty figured it out :)
12944qwerty
requested changes
Apr 12, 2024
FedeIlLeone
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uhhh yeah something something lint fix and recovery.
DO NOT MERGE YET
Specifically made this pr for reviewing types.