Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable filesystem performance collector/analyser #107

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Nov 22, 2024

The collector adds up to 2mins to the collection process. Ideally, this add about 10 more seconds

If fio takes 2mins to do its thing, the process gets interrupted by support-bundle process

@adamancini
Copy link
Member

This change makes it so that we do run the filesystem performance collector in our specs?

@banjoh
Copy link
Member Author

banjoh commented Nov 22, 2024

This change makes it so that we do run the filesystem performance collector in our specs?

Correct

@banjoh
Copy link
Member Author

banjoh commented Nov 22, 2024

This collector/analyser was disabled intentionally. The reason is unknown, but best not to enable it. Closing PR

@banjoh banjoh closed this Nov 22, 2024
@adamancini adamancini reopened this Nov 22, 2024
@adamancini
Copy link
Member

It looks to me like this was merged into our spec in the exclude: true state; it wasn't changed in our history, so I'm thinking this might have been pulled in from the old spec at kots.io - in any case we talked about this in Slack and think this should get turned on.

@adamancini adamancini merged commit 0ef865d into replicatedhq:main Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants