add debug logging for the kotsadm startup process #5019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a debug log after each major startup function add a 'this is still waiting' debug message in the db and filestore wait loops use the context-aware s3 client function
sgalsaleh
reviewed
Nov 25, 2024
| @@ -145,6 +167,7 @@ func Start(params *APIServerParams) { | |||
| log.Println("Failed to run automated installs:", err) | |||
| } | |||
| } | |||
| logger.Debug("automated airgap installs are completed") | |||
There was a problem hiding this comment.
i would be confused if i saw this in an online install
There was a problem hiding this comment.
Suggested change
| logger.Debug("automated airgap installs are completed") | |
| logger.Debug("automated airgap installs are completed if requested") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Debugging why kotsadm is not starting is quite painful. We can make this easier by:
adding a debug log after each major startup function
adding a 'this is still waiting' debug message in the db and filestore wait loops
We can also surface timeouts in the s3 connection function by using the context-aware s3 client function.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?