Bug Fix: Set timeout on requests.get #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tempusfrangit
requested review from
nickstenning,
meatballhat and
philandstuff
tempusfrangit
force-pushed
the
requests-timeout
branch
2 times, most recently
from
9277997
to
b07e7ec
Compare
philandstuff
force-pushed
the
requests-timeout
branch
3 times, most recently
from
fe857c3
to
586b03e
Compare
If you don't set a timeout, your request may hang indefinitely. The timeout parameter is used for connect and read timeouts. The whole request may take longer than the timeout; but if the connection takes longer than the timeout, or if the connection fails to send more data for an interval longer than the timeout, it will fail. I chose 5 seconds for the upload_file, which (at least when run on replicate infrastructure) is always to an endpoint in the same data center. I chose 10 seconds for downloading URLFile inputs as they may be making a request over the public internet. Co-authored-by: Philip Potter <[email protected]>
philandstuff
force-pushed
the
requests-timeout
branch
from
586b03e
to
85a1624
Compare
philandstuff
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If requests.get has no timeout it is possible to hang indefinitely on a ill behaved webserver. This timeout is explicitly a connect and read timeout, meaning if no bytes received.