Support custom filename to be provided to URLFile #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit works around an issue where the basename of the URL many not actually contain a file extension and the uploader logic cannot infer the mime type for the file. We stash the name when pickling and extract it again when unpickling. The __getattr__ function then supports returning the underlying name value rather than proxying to the underlying request object. I also ran into a small bug whereby the __del__ method was triggering a network request because of some private attributes being accessed during teardown would trigger the __wrapper__ code. I've overridden the super class to disable this. Though I'm unclear if this is just the test suite doing this cleanup.
meatballhat
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit works around an issue where the basename of the URL many not
actually contain a file extension and the uploader logic cannot infer
the mime type for the file.
We stash the name when pickling and extract it again when unpickling.
The getattr function then supports returning the underlying name
value rather than proxying to the underlying request object.
I also ran into a small bug whereby the del method was triggering
a network request because of some private attributes being accessed
during teardown would trigger the wrapper code. I've overridden
the super class to disable this. Though I'm unclear if this is just the
test suite doing this cleanup.