Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recent blog posts on homepage #37

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add recent blog posts on homepage #37

merged 1 commit into from
Aug 9, 2024

Conversation

anchalshivank
Copy link
Contributor

  • Implemented a custom blog plugin to generate recent-posts.json
  • Integrated recent-posts.json data into RecentBlogs component
  • Enhanced RecentBlog component to include title, date, reading time, and description
  • Added CSS modules for styling RecentBlog and RecentBlogs components

sergefdrv
sergefdrv requested changes Aug 7, 2024
View reviewed changes
src/pages/index.jsx Outdated Show resolved Hide resolved
plugins/blog-plugin.js Outdated Show resolved Hide resolved
src/components/RecentBlogs/index.jsx Outdated Show resolved Hide resolved
src/components/RecentBlog/index.module.css Outdated Show resolved Hide resolved
@anchalshivank anchalshivank requested a review from sergefdrv August 7, 2024 17:37
sergefdrv
sergefdrv requested changes Aug 8, 2024
View reviewed changes
plugins/blog-plugin.js Outdated Show resolved Hide resolved
src/components/RecentBlog/index.jsx Outdated Show resolved Hide resolved
src/components/RecentBlog/index.jsx Outdated Show resolved Hide resolved
src/components/RecentBlogs/index.jsx Outdated Show resolved Hide resolved
src/pages/index.jsx Outdated Show resolved Hide resolved
src/components/RecentBlogs/index.jsx Outdated Show resolved Hide resolved
src/components/RecentBlogs/index.jsx Outdated Show resolved Hide resolved
src/components/RecentBlog/index.jsx Outdated Show resolved Hide resolved
plugins/blog-plugin.js Outdated Show resolved Hide resolved
@anchalshivank anchalshivank requested a review from sergefdrv August 8, 2024 14:49
@anchalshivank anchalshivank requested a review from sergefdrv August 8, 2024 15:40
sergefdrv
sergefdrv requested changes Aug 8, 2024
View reviewed changes
Copy link
Member

@sergefdrv sergefdrv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, save for a few nit-picking suggestions, this PR looks nice! Please apply the suggestions and squash the commits 👍

src/components/RecentBlogPosts/index.jsx Outdated Show resolved Hide resolved
src/pages/index.jsx Outdated Show resolved Hide resolved
src/pages/index.jsx Outdated Show resolved Hide resolved
@anchalshivank anchalshivank force-pushed the feature/add-recent-blog-post-on-homepage branch from cdf80a5 to bd7be13 Compare August 9, 2024 04:18
@anchalshivank anchalshivank requested a review from sergefdrv August 9, 2024 04:18
sergefdrv
sergefdrv requested changes Aug 9, 2024
View reviewed changes
Copy link
Member

@sergefdrv sergefdrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final nit-picking. The commit message should not mention the history of the PR (like "Enhanced RecentBlogPost component"). Instead, it would better tell why we had to hack around the blog plugin. The rest seems to be quite self-explanatory.

src/pages/index.jsx Outdated Show resolved Hide resolved
src/pages/index.jsx Outdated Show resolved Hide resolved
src/components/RecentBlogPosts/index.jsx Outdated Show resolved Hide resolved
src/components/RecentBlogPosts/index.jsx Outdated Show resolved Hide resolved
@sergefdrv sergefdrv linked an issue Aug 9, 2024 that may be closed by this pull request
Show recent blog posts on homepage #10
Closed
@anchalshivank
Add recent blog posts on homepage
10ad9f7 
- Implemented custom plugin to generate `blog-posts-metadata.json`
- Integrated `blog-posts-metadata.json` data into RecentBlogPosts component
- Added `recentBlogPostsOnHomePage` parameter in `customFields` in `docusaurus.config.js`

Signed-off-by: Shivank Anchal <[email protected]>
@anchalshivank anchalshivank force-pushed the feature/add-recent-blog-post-on-homepage branch from ee24cdd to 10ad9f7 Compare August 9, 2024 17:34
@anchalshivank anchalshivank requested a review from sergefdrv August 9, 2024 17:35
sergefdrv
sergefdrv approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@sergefdrv sergefdrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks 🙏

@sergefdrv sergefdrv merged commit 9915d83 into replica-io:main Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergefdrv sergefdrv sergefdrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show recent blog posts on homepage
2 participants
@anchalshivank @sergefdrv