Skip to content

Commit

Permalink
Use updated ReactOwnerRenders mode
Browse files Browse the repository at this point in the history
  • Loading branch information
Andarist committed Nov 26, 2024
1 parent 9acf667 commit 1d5b860
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions packages/shared/client/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -293,9 +293,9 @@ export type DependencyChainStep = DependencyChainStepInfo & {
};

export enum DependencyGraphMode {
// Renders of a fiber depend on the last time the parent of that fiber was
// Renders of a fiber depend on the last time the owner of that fiber was
// rendered, instead of whatever triggered the fiber's render.
ReactParentRenders = "ReactParentRenders",
ReactOwnerRenders = "ReactOwnerRenders",
}

export interface ReplayClientInterface {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export default function SecondaryPanes() {
onToggle={() => setReactDependencyGraphVisible(!reactDependencyGraphVisible)}
>
<DependencyGraph
mode={DependencyGraphMode.ReactParentRenders}
mode={DependencyGraphMode.ReactOwnerRenders}
point={timeStampedPoint?.point}
/>
</AccordionPane>
Expand Down
2 changes: 1 addition & 1 deletion src/ui/suspense/depGraphCache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ export const reactComponentStackCache: Cache<
const reactDependencies = await depGraphCache.readAsync(
replayClient,
point.point,
DependencyGraphMode.ReactParentRenders
DependencyGraphMode.ReactOwnerRenders
);

if (!originalDependencies || !reactDependencies) {
Expand Down

0 comments on commit 1d5b860

Please sign in to comment.