Replace PQconnectdb() by PQconnectdbParams()

[za-arthur]

A value in a connection string should be quoted if it can contain spaces:
https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING-KEYWORD-VALUE

Alternative approach is to use PQconnectdbParams() instead of PQconnectdb(). This should be more solid approach to pass password and other connection options, which doesn't require escaping value strings.

Issue: #382

[jschaf]

This would fix my issue--left a suggestion for covering all cases.

[jschaf]

That'll work for most passwords (and mine), but this approach won't work for passwords that contain single quotes.

https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING-KEYWORD-VALUE

To make it bulletproof: when wrapping with single quotes, we'd need to scan the string and:

• Prefix any backslash with a backslash.
• Prefix any single quote with a backslash.

[za-arthur]

That makes sense 👍. I see couple of ways of resolving other cases:

• The simpler approach is to copy the function appendConnStrVal(). libpgfeutils started sharing it only after Postgres 9.6.
• IMHO the proper approach would be to use PQconnectdbParams(), which doesn't require connection parameters values and which is used by most of the PostgreSQL client applications.

[za-arthur]

With the commit 135df8b I replaced call of PQconnectdb() by PQconnectdbParams(). This should be more solid approach to pass password and other connection options, which doesn't require escaping value strings.

[jschaf]

Much appreciated! I don't see anything glaringly wrong, but I have very little C experience.

[andreasscherbaum]

Looks good. Thanks for keeping older versions alive.

[za-arthur]

Thanks for the approval. I'm merging the PR.