-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #338: Remove old EOL PostgreSQL versions #374
Conversation
Objection: the Unit Tests are not failing, which implies that If we add a feature which breaks compatibility with older versions, there's no point in fixing that. But that's the time we can update the documentation and clearly state that we know it is no longer working with version xyz. If tests for older versions are removed now, there is no information as to if the tool works or not. |
Reasonable. We probably also need to remove obsolete regress/travis_prepare.sh and regress/travis_test.sh |
I agree on the Travis part. |
I remember that there was a problem installing such old versions of postgresql for autotesting. I'm actually a little surprised that the pg10 test still works on github workflows. I think it will stop working in the spring (after the next ubuntu-latest is released). |
I'll add old postgres versions into the workflow to see which versions fail. |
By ede9bc3 I fixed tests for Postgres 9.6, 9.5. Postgres couldn't get
And therefore Now it seems Postgres 9.4 fails because of compilation errors. I think it isn't worth to try to fix them and I will delete Postgres 9.4 from tests. |
Please also update the docs at the same time stating that it is known that 9.4 no longer works. That's the whole point of keeping the old tests around. |
Done, without translation to Japanese. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Currently we test only Postgresql from 10 to 16:
pg_repack/.github/workflows/regression.yml
Lines 10 to 16 in 6263dd5
And we cannot guarantee that older PostgreSQL versions work correctly.
Issue: #338