Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #338: Remove old EOL PostgreSQL versions #374

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

za-arthur
Copy link
Collaborator

Currently we test only Postgresql from 10 to 16:

- 16
- 15
- 14
- 13
- 12
- 11
- 10

And we cannot guarantee that older PostgreSQL versions work correctly.

Issue: #338

@andreasscherbaum
Copy link
Collaborator

Objection: the Unit Tests are not failing, which implies that pg_repack is working on the older versions.
The tests on older versions should be kept as an indication as to when pg_repack is failing on older PostgreSQL versions.

If we add a feature which breaks compatibility with older versions, there's no point in fixing that. But that's the time we can update the documentation and clearly state that we know it is no longer working with version xyz. If tests for older versions are removed now, there is no information as to if the tool works or not.

@Melkij
Copy link
Collaborator

Melkij commented Nov 28, 2023

Reasonable. We probably also need to remove obsolete regress/travis_prepare.sh and regress/travis_test.sh

@andreasscherbaum
Copy link
Collaborator

I agree on the Travis part.

@Melkij
Copy link
Collaborator

Melkij commented Nov 28, 2023

I remember that there was a problem installing such old versions of postgresql for autotesting. I'm actually a little surprised that the pg10 test still works on github workflows. I think it will stop working in the spring (after the next ubuntu-latest is released).

@za-arthur
Copy link
Collaborator Author

I'll add old postgres versions into the workflow to see which versions fail.

@za-arthur
Copy link
Collaborator Author

By ede9bc3 I fixed tests for Postgres 9.6, 9.5. Postgres couldn't get create_table column type and showed warning:

  CREATE EXTENSION pg_repack;
+ WARNING:  column "create_table" has type "unknown"
+ DETAIL:  Proceeding with relation creation anyway.

And therefore init-extension tests output didn't match with expected output.

Now it seems Postgres 9.4 fails because of compilation errors. I think it isn't worth to try to fix them and I will delete Postgres 9.4 from tests.

@andreasscherbaum
Copy link
Collaborator

Postgres 9.4

Please also update the docs at the same time stating that it is known that 9.4 no longer works.

That's the whole point of keeping the old tests around.

@za-arthur
Copy link
Collaborator Author

Please also update the docs at the same time stating that it is known that 9.4 no longer works.

Done, without translation to Japanese.

Copy link
Collaborator

@andreasscherbaum andreasscherbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@za-arthur za-arthur merged commit 624745b into master Nov 29, 2023
18 checks passed
@za-arthur za-arthur deleted the issue_338_update_pg_versions branch November 29, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for all old EOL'd PG versions and solving all racing conditions?
3 participants