Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for postgresql 16 #345

Closed
wants to merge 1 commit into from

Conversation

Melkij
Copy link
Collaborator

@Melkij Melkij commented Apr 3, 2023

Hello

So far there are no incompatible changes, 1.4.8 works with postgresql 16dev without any changes.

However, I propose to prepare a new release 1.4.9 as usual, I will mention postgresql 16 support in the change notes to eliminate any ambiguity.

Question for discussion: it is necessary to change the list of supported old versions? ( #338 )

PS: at the same time I want to check if pg16 is already available for our tests

@Melkij
Copy link
Collaborator Author

Melkij commented Apr 3, 2023

update-alternatives: error: alternative path /usr/share/postgresql/16/man/man1/postmaster.1.gz doesn't exist
dpkg: error processing package postgresql-16 (--configure):
installed postgresql-16 package post-installation script subprocess returned error exit status 2

The package is available, but its installation fails. I'll trigger the check few weeks later.

@Melkij Melkij marked this pull request as draft April 3, 2023 16:33
@andreasscherbaum
Copy link
Collaborator

andreasscherbaum commented Apr 20, 2023

This is currently failing with an unrelated error in the package:

update-alternatives: error: alternative path /usr/share/postgresql/16/man/man1/postmaster.1.gz doesn't exist
dpkg: error processing package postgresql-16 (--configure):
 installed postgresql-16 package post-installation script subprocess returned error exit status 2

META.json Outdated
@@ -2,7 +2,7 @@
"name": "pg_repack",
"abstract": "PostgreSQL module for data reorganization",
"description": "Reorganize tables in PostgreSQL databases with minimal locks",
"version": "1.4.8",
"version": "1.4.9",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to separate the update of support for PG 16 and the cut of a new release. These two do not necessarily have to go into a single PR.

@andreasscherbaum
Copy link
Collaborator

We are discussing that instead of releasing 1.4.9 we release 1.5.0 as compatibility release for PG 16.

@Melkij Can you please rebase this patch? Thanks!

add postgresql 16 to tests, no other changes seem to be needed
@Melkij Melkij force-pushed the support_for_postgresql_16 branch from edbce64 to cc0870d Compare June 14, 2023 11:49
@Melkij
Copy link
Collaborator Author

Melkij commented Jun 14, 2023

I removed unrelated changes and ran tests locally. For postgresql 16 we didn't need any additional changes. This time, the github tests also passed without surprises.

@Melkij Melkij marked this pull request as ready for review June 14, 2023 11:58
@franciscoreinolds
Copy link

Greetings!

Any news in regards to this? 👀

@Melkij
Copy link
Collaborator Author

Melkij commented Sep 25, 2023

@franciscoreinolds , pg_repack 1.4.8 works fine with postgresql 16. No code changes were required. Regarding the mention of pg16 support in the documentation and tests... I lost the track.

@andreasscherbaum , I remember that a new release was planned.

@franciscoreinolds
Copy link

Indeed, I meant more if there had been a discussion to release a new version with the content of this PR just to explicitly support PG 16 👌🏽

@andreasscherbaum
Copy link
Collaborator

Yes, there is a bugfix we want to get in, and then release a version which mentions 16.

@@ -7,6 +7,7 @@ jobs:
fail-fast: false
matrix:
pg:
- 16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file doc/pg_repack.rst must be updated too to declare the next version pg16-compatible.

@za-arthur
Copy link
Collaborator

This was done by #364 and #372

@za-arthur za-arthur closed this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants