Don't implement keyPathsForValuesAffectingValueForKey if it will do n… #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…othing but call super If there are no `noninheritedAttributes` then the `for` loop will do nothing, and the whole method does nothing but call super really. So where that's the case, just don't implement the method at all. There are other cases where the `for` loop could end up doing nothing, this doesn't eliminate all such cases, just this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…othing but call super
If there are no
noninheritedAttributesthen theforloop will do nothing, and the whole method does nothing but call super really.So where that's the case, just don't implement the method at all.
There are other cases where the
forloop could end up doing nothing, this doesn't eliminate all such cases, just this one.