feat: update atlaskit package preset for changelog retrieval #32690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <[email protected]>
viceice
requested changes
Nov 23, 2024
setchy
changed the title
sourceUrl and sourceDirectory for changelogs
Signed-off-by: Adam Setch <[email protected]>
updated description now that #32701 landed |
setchy
changed the title
sourceUrl and sourceDirectory for changelogs
rarkins
reviewed
Nov 26, 2024
Comment on lines
+22
to
+23
| sourceDirectory: "design-system/{{ lookup (split packageName '/') 1 }}", | ||
| sourceUrl: 'https://bitbucket.org/atlassian/atlassian-frontend-mirror', |
There was a problem hiding this comment.
I don't think we set anything in any of these packages: presets. Until now they're purely "matching" rules which only work if extended
There was a problem hiding this comment.
Thanks for the feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update atlaskit package rule to include
sourceUrlandsourceDirectoryfor changelog retrievalContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: