Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bitbucket): source link root path #32689

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Nov 23, 2024

Changes

Source URL path for Bitbucket Cloud is src/ not tree/

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy added the platform:bitbucket Bitbucket Cloud platform label Nov 23, 2024
@@ -1,6 +1,7 @@
import type { RenovateConfig } from '../../../../../config/types';
import type { PrDebugData } from '../../../../../modules/platform';
import { platform } from '../../../../../modules/platform';
import { BITBUCKET_WEB_ENDPOINT } from '../../../../../modules/platform/bitbucket';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export a new optional platform API instead, we don't want to have deep import from platforms here.

Copy link
Collaborator Author

@setchy setchy Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think that will work since its not the renovate platform, but the specific update platform/host that I need to check

eg: renovate running on a GitHub repository with an update for a Bitbucket-hosted package

is there another way to achieve this? essentially I want to check the updates host type (bitbucket, github, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:bitbucket Bitbucket Cloud platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants