-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(maven): Add maven relocation support #32550
base: main
Are you sure you want to change the base?
feat(maven): Add maven relocation support #32550
Conversation
@jonasrutishauser thanks for this interesting feature. Could you share an example repo you've tested against? |
I created a simple example repo https://github.com/jonasrutishauser/renovate-32550 and I have run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please split this PR into three parts
- worker
- datasource
- manager
you can use this PR for one of them and the order probably doesn't matter.
9057d1b
to
b6fb822
Compare
@jonasrutishauser, do we understand why on your test repo, there's no PR for Ant 1.7.0? Is that just a matter of throttling, or is there a reason why the replacement does not get noticed? |
I think the reason is, that the version 1.7.0 has no timestamp in the html and is therefore ignored/not seen. In the |
const { updates } = await Result.wrap( | ||
lookup.lookupUpdates(config), | ||
).unwrapOrThrow(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const { updates } = await Result.wrap( | |
lookup.lookupUpdates(config), | |
).unwrapOrThrow(); | |
const { updates } = await lookup.lookupUpdates(config); |
no need to wrap here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With your suggestion I receive Property 'updates' does not exist on type 'Result<UpdateResult, Error>'.ts(2339)
.
The only working code would be the following:
const { updates } = (await lookup.lookupUpdates(config)).unwrapOrThrow();
As all other tests don't use this variant, I think it shouldn't be changed.
Changes
Use maven relocation information to detect package name changes and allow replacement updates for maven.
Context
Closes #5667.
Documentation (please check one with an [x])
The issue #14149 should be updated after merging this.
How I've tested my work (please select one)
I have verified these changes via: