fix(go): Remove deprecated '-d' flag when doing 'go get'

[echarrod]

Changes

• Remove deprecated -d flag from go get.

Context

• This flag was changed to have no effect in Go 1.18
• Go's release policy only officially support the latest two major versions, i.e. 1.23 and 1.22 at the moment

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[echarrod]

Ah I see we're using older versions of Go elsewhere, maybe we should update those at the same time 🤔

[rarkins]

Usually Renovate will use the latest Go version, but users may pin to an older version. Therefore we ideally would look at the go.mod directive and decide on -d based on the version in use

[viceice]

extract go version from go and / or toolchain directive. drop -d only if it is >=1.18.

[echarrod]

Sorry was just about to comment: I made an update to update Go version after I realised it was currently older: #32514

[echarrod]

Usually Renovate will use the latest Go version, but users may pin to an older version. Therefore we ideally would look at the go.mod directive and decide on -d based on the version in use

Thanks for the response, I wouldn't have guessed anyone is on an older version, given Go's release policy of only officially support the latest two major versions, i.e. 1.23 and 1.22 at the moment.

It also means you can barely upgrade to any libraries at all if you're on < 1.18, so I wouldn't have thought it would be feasible to do this and run Renovate!

[viceice]

🤔 go v1.17 was realesed ~3 years ago. https://go.dev/blog/go1.17

https://github.com/search?q=%22go+1.17%22++NOT+is%3Aarchived+path%3Ago.mod&type=code

It seems there are some repos with go v1.17.

@secustor @rarkins Can we really assume someone uses go <1.18 and also is using renovate?

I think @echarrod is right and we can assume any update needs a newer go version now.

[rarkins]

Go is a little bit unique though because even if a repo has a go mod directive of 1.17, this means "Use Go 1.17 compatibility" and not "Use Go 1.17". i.e. it's not like a .nvmrc file. So Renovate intentionally runs the latest 1.x Go no matter what the Go mod directive says, because Go is backwards compatible. The only way removing this flag could cause problems is if a user pinned to an older exact version using constraints.

[rarkins]

Can we detect if someone has pinned their go constraints, or should we assume they won't?

[viceice]

Can we detect if someone has pinned their go constraints, or should we assume they won't?

we can detect

[echarrod]

Hey all 👋
Is this the blocker for this MR:

• if:
  • a user has pinned their go constraint
  • and it's < 1.18
• still use -d in go get?

[viceice]

yes, as told before