Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer Renovate's togithub.com redirect domain to GitHub #29370

Closed
HonkingGoose opened this issue May 31, 2024 · 14 comments
Closed

Transfer Renovate's togithub.com redirect domain to GitHub #29370

HonkingGoose opened this issue May 31, 2024 · 14 comments
Assignees
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@HonkingGoose
Copy link
Collaborator

Describe the proposed change(s).

Renovate's togithub.com redirect domain got blocked by GitHub's Umbrella protection system. This block is now reverted, so the redirect works properly again. But maybe having the domain controlled by GitHub officially is better.

@rarkins said:

I would be happy to transfer togithub.com to GitHub naturally - the community would benefit by being able to link to GitHub endpoints without triggering backlinks

I suspect something like https://to.github.com/ would be better long term, with a 301 permanent redirect from togithub.com to to.github.com. Alternatively having GitHub unblock togithub.com it is suitable :)

@gr2m offered to contact somebody from GitHub about transferring the domain to GitHub, and will ping us when they hear something.

Related discussion:

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code labels May 31, 2024
@HonkingGoose

This comment was marked as resolved.

@gr2m
Copy link

gr2m commented May 31, 2024

sure 👋

Can you explain why something like togithub.com is even needed? Why not just link directly to the correct github.com link?

@rarkins
Copy link
Collaborator

rarkins commented May 31, 2024

Direct links cause "backlink spam". The worst is when release notes include a username. That person could wake up to hundreds or thousands of GitHub notifications. But even merged PRs could get pages of annoying back links from every public repository which gets an upgrade PR referencing it

@HonkingGoose
Copy link
Collaborator Author

I'll assign both of you to the issue, because we need @gr2m for the making-contact-phase, and @rarkins later for the transfer.

@gr2m
Copy link

gr2m commented May 31, 2024

The worst is when release notes include a username. That person could wake up to hundreds or thousands of GitHub notifications

I don't think that happens if you escape them, which I think you already do? @gr2m -> [@gr2m](https://github.com/gr2m) (example). I just tried if the same works with links to avoid backlinks, but that didn't work. It seems not to matter what is used as label, the backlink shows up if the link is a valid issue URL

I only know the togithub.com redirect URLs from the package link, like here: semantic-release/semantic-release#3326, where it just links to the repository

screenshot

This could be linked directly to the repository, right?

From what you are saying is that you replace all github.com links with the togithub.com domain?

@rarkins
Copy link
Collaborator

rarkins commented May 31, 2024

We replace all to be careful. Otherwise you can't escape them enough without breaking the links

@rarkins
Copy link
Collaborator

rarkins commented May 31, 2024

We also don't want the task of playing "catch up" every time there's some new way we discover to accidentally backlink and someone gets spammed for a while. This approach has been successful for years now!

@gr2m
Copy link

gr2m commented May 31, 2024

The problem is notification and backlink spam, right? Using togithub.com is a solution to that, but maybe there is something else that GitHub can do. I'll think about it and see if I find folks within GitHub to talk about it

@rarkins
Copy link
Collaborator

rarkins commented Jun 1, 2024

That's exactly right

@HonkingGoose
Copy link
Collaborator Author

HonkingGoose commented Jun 1, 2024

The problem is notification and backlink spam, right? Using togithub.com is a solution to that, but maybe there is something else that GitHub can do.

What if as GitHub app creator you could select a backlink mode?

By default, GitHub would not show backlinks, to prevent bot/app creators from accidentally spamming a repository/users with links. The new default would be a breaking change compared to the current default behavior!

Currently GitHub will link back for every reference to an Issue or PR.

If you do want the app/bot to backlink to Issues, PRs, you can opt-in with a special toggle. This toggle should have clear text explaining the behavior you'll get, and ask again if you're sure! Like how GitHub asks you to be really sure and confirm again for "potentially dangerous/difficult to revert actions" like transferring repo ownership, making a private repo public and so on.

If GitHub wants to keep the current behavior as default, that's fine also. The main thing is to give app/bot creators a choice. And to give creators peace of mind they're not accidentally spamming users.

@Valexaa

This comment has been minimized.

@HonkingGoose
Copy link
Collaborator Author

@oliviertassinari said: 1

Dependabot uses redirect.github.com maybe a better option.

I'll let the maintainers decide which is best:

  • Give our togithub.com domain to GitHub, or
  • Drop our custom togithub.com domain, and use official redirect.github.com

If we decide to use the official redirect domain, we probably should ask for permission from GitHub first? That's because Renovate creates a lot of redirect links, and has a lot of users.

Footnotes

  1. https://github.com/renovatebot/renovate/discussions/10796#discussioncomment-10413066

@rarkins
Copy link
Collaborator

rarkins commented Aug 23, 2024

We should use redirect.github.com

@rarkins
Copy link
Collaborator

rarkins commented Aug 23, 2024

@HonkingGoose maybe let's open a new issue and supersede/close this one

@rarkins rarkins closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Development

No branches or pull requests

4 participants