Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub's official redirect.github.com domain and drop togithub.com domain #30980

Closed
1 task done
HonkingGoose opened this issue Aug 23, 2024 · 3 comments · Fixed by #31025
Closed
1 task done

Use GitHub's official redirect.github.com domain and drop togithub.com domain #30980

HonkingGoose opened this issue Aug 23, 2024 · 3 comments · Fixed by #31025
Assignees
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:refactor Refactoring or improving of existing code

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Aug 23, 2024

Describe the proposed change(s).

Todos

  • Replace togithub.com with redirect.github.com in our code.

Context

Our custom togithub.com domain sometimes gets blocked by GitHub's Umbrella protection system. We then need to contact GitHub to get unblocked.

To get around the "we get blocked by GitHub problem" we wanted to transfer control of the custom domain to GitHub. But that went nowhere:

In the issue above, a user suggested we use redirect.github.com instead, and @rarkins agreed.

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started labels Aug 23, 2024
@HonkingGoose
Copy link
Collaborator Author

Questions for @rarkins:

  1. How to confirm the new domain works as expected? Worst case scenario: we deploy the change, it does not work as we expect, and we ping everybody... 😱

  2. Short term: Mend should keep control of the old custom domain for a while, so we can revert to the old state if needed.

  3. Long term: should Mend keep controlling the old domain? Say someone with bad plans buys the old domain, and somehow messes things up for Renovate users?

  4. Do we need to write code to check if Renovate config files mention the old domain togithub.com? I'm thinking of users that somehow hard-coded Renovate to use that domain, which could become a risk when Mend drops the domain?

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Aug 23, 2024

Regarding point 4.

We use the links with users in 2 cases:

  1. Comments/ PR body: Can be tested using github ui

  2. Commit message/body: Can be tested by making a git commit

No need to write code IMO, except test runs on the PR which introduces this change.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.57.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:refactor Refactoring or improving of existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants