auth-server: fix repeated decimal correction #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeykraut
approved these changes
Jan 1, 2025
sehyunc
force-pushed
the
sehyun/fix-ratio
branch
2 times, most recently
from
a69edad to
79aeed4
Compare
sehyunc
force-pushed
the
sehyun/fix-ratio
branch
from
79aeed4 to
ffd1026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a bug where the price of a quote was doubly decimal corrected, resulting in incorrect fill ratio metrics. The post-decimal-fix tag will be used to filter out any incorrect metrics in DD.
Testing