Refactor command line flag handling for plugins #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flags are now created with the `Flag.create` function. These are then converted into the strings Arg.parse and similar use in `src/bin/sail.ml`. The output of `sail -h` remains the same, so no actual flags have changed. Flags can now have more data, i.e. rather than "-lem_split_files", it can now be: ``` Flag.create ~prefix:["lem"] "split_files" ``` meaning we can now recognize this flag is part of the lem options and parse it from e.g. a JSON configuration file as `lem.split_files`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags are now created with the
Flag.createfunction.These are then converted into the strings Arg.parse and similar use in
src/bin/sail.ml. The output ofsail -hremains the same, so no actual flags have changed.Flags can now have more data, i.e. rather than "-lem_split_files", it can now be:
meaning we can now recognize this flag is part of the lem options and parse it from e.g. a JSON configuration file as
lem.split_files(although this is not done as part of this PR).