Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mac binary releases #809

Open
wants to merge 1 commit into
base: sail2
Choose a base branch
from

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Dec 4, 2024

Add support to the release.yml Github Actions workflow for building a Mac binary. Unfortunately I got weird Git errors from OPAM when using --filter=tree:0 so I had to remove it. Otherwise this is fairly simple.

I also upgraded the OCaml version to match build.yml.

Copy link

github-actions bot commented Dec 4, 2024

Test Results

   12 files  ±0     24 suites  ±0   0s ⏱️ ±0s
  738 tests ±0    738 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 466 runs  ±0  2 465 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit bf4ccd4. ± Comparison against base commit fd18b93.

♻️ This comment has been updated with latest results.

@arichardson
Copy link
Contributor

This looks like a great idea. I think the best thing would be if we could get sail into homebrew to make it easy to install.

I created a formula that probably no longer works a few years ago but no longer feel like upstreaming it since I had some less than ideal experiences dealing with homebrew... In case anyone would like to try here is my formula: https://github.com/arichardson/homebrew-cheri/blob/main/Formula/sail.rb

Add support to the release.yml Github Actions workflow for building a Mac binary. Unfortunately I got weird Git errors from OPAM when using `--filter=tree:0` so I had to remove it. Otherwise this is fairly simple.

I also upgraded the OCaml version to match build.yml.
@Timmmm Timmmm force-pushed the user/timh/mac_release branch from 2f1ff09 to bf4ccd4 Compare December 19, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants